[
https://issues.apache.org/jira/browse/KAFKA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851416#comment-17851416
]
MOHD KAIF KHAN commented on KAFKA-16871:
----------------------------------------
[~ableegoldman] So far here's what I have done -
1. Remove the old static inner class AssignorConfiguration.AssignmentConfigs
2. Replace the usage of this internal class in other classes, by replacing them
with corresponding getters of new AssignmentConfigs class wherever required.
3. I found one issue in doing step 2 above -
the new public AssignmentConfigs class has few properties like
`rackAwareTrafficCost` with type as primitive int, whereas the old
corresponding static class in AssignorConfiguration had this field as Integer.
There are some null checks on this field in few classes, e.g.
HighAvailabilityTaskAssignor, doing something like configs.
rackAwareAssignmentTrafficCost == null ... which cant be done with primitives
if replaced.
I checked in the KIP, its mentioned as OptionalInt, suggesting that this field
can be null, but in the new AssignmentConfigs impl it was `int`.
Any suggestion on this would be very helpful.
> Clean up internal AssignmentConfigs class in Streams
> ----------------------------------------------------
>
> Key: KAFKA-16871
> URL: https://issues.apache.org/jira/browse/KAFKA-16871
> Project: Kafka
> Issue Type: Sub-task
> Reporter: A. Sophie Blee-Goldman
> Priority: Major
> Labels: newbie, newbie++
>
> In KIP-924 we added a new public AssignmentConfigs class to hold all of the,
> you guessed it, assignment related configs.
> However, there is an existing config class of the same name and largely the
> same contents but that's in an internal package, specifically inside the
> AssignorConfiguration class.
> We should remove the old AssignmentConfigs class that's in
> AssignorConfiguration and replace any usages of it with the new public
> AssignmentConfigs that we added in KIP-924
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
