jolshan commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1622699466
##########
core/src/test/java/kafka/test/ClusterInstance.java:
##########
@@ -159,9 +158,7 @@ default Set<GroupProtocol> supportedGroupProtocols() {
Set<GroupProtocol> supportedGroupProtocols = new HashSet<>();
supportedGroupProtocols.add(CLASSIC);
- // KafkaConfig#isNewGroupCoordinatorEnabled check both
NEW_GROUP_COORDINATOR_ENABLE_CONFIG and
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG
- if (serverProperties.getOrDefault(NEW_GROUP_COORDINATOR_ENABLE_CONFIG,
"").equals("true") ||
Review Comment:
Hmmm -- so when you say the new group coordinator -- you mean the code
(which handles both protocols) and not the protocol itself.
Do I have this right?
1. If the protocol is consumer -> new coordinator
2. If the config is enabled -> new coordinator
3. If protocol is not consumer && config is not enabled -> old coordinator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
