lianetm commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1622679624
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegateTest.java:
##########
@@ -140,6 +141,25 @@ public void testEnsureTimerSetOnAdd() {
assertEquals(REQUEST_TIMEOUT_MS,
ncd.unsentRequests().poll().timer().timeoutMs());
}
+ @Test
+ public void testHasAnyPendingRequests() throws Exception {
+ try (NetworkClientDelegate networkClientDelegate =
newNetworkClientDelegate()) {
+ NetworkClientDelegate.UnsentRequest unsentRequest =
newUnsentFindCoordinatorRequest();
+ networkClientDelegate.add(unsentRequest);
+ // unsent
+ assertTrue(networkClientDelegate.hasAnyPendingRequests());
+ assertFalse(networkClientDelegate.unsentRequests().isEmpty());
+ assertFalse(client.hasInFlightRequests());
+
+ networkClientDelegate.poll(0, time.milliseconds());
+
+ // in-flight
+ assertTrue(networkClientDelegate.hasAnyPendingRequests());
+ assertTrue(networkClientDelegate.unsentRequests().isEmpty());
+ assertTrue(client.hasInFlightRequests());
Review Comment:
to cover the whole flow, what about extending the test to ensure that when
we get a response, the `hasAnyPendingRequests` goes false? (there's a
`prepareFindCoordinatorResponse` that should be handy for it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
