loicgreffier commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1619321278


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -764,6 +766,7 @@ public boolean process(final long wallClockTime) {
 
             // get the next record to process
             record = partitionGroup.nextRecord(recordInfo, wallClockTime);
+            rawRecord = partitionGroup.rawHeadRecord();

Review Comment:
   We did not really consider it as it appears more impactful for us to add a 
new attribute to `ProcessorRecordContext` (more code/unit tests changes 
basically) but we can definitely reconsider it.
   
   Also we'll need to update the production exception handling 
(https://github.com/apache/kafka/blob/0f0c9ecbf330923ad653cc2ff4fca6c4dced1cf7/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L223)
 accordingly to KIP-1033. Having the raw record in the `ProcessorRecordContext` 
would help us on this part. Let us try that!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to