gharris1727 commented on PR #16035: URL: https://github.com/apache/kafka/pull/16035#issuecomment-2135540100
@fanyang Yes I think you understand. Your example is exactly the situation that needs improvement here. Something similar to the Projectable interface is necessary, but I don't know the exact details yet, as we will need to work it out. There are also some classloading concerns about a Projectable implementation being in a different classloader than the plugin using SchemaProjector. For example, if plugin A had the AvroConverter and the AvroEnumProjectable, and plugin B called SchemaProjector.project(..., avroEnum, ...), how would the SchemaProjector safely find and execute the AvroEnumProjectable? You can think about these things and put together a proposal. I'm happy to answer any questions that you have. You can take a look at some of the isolation code https://github.com/apache/kafka/tree/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation and read the most relevant KIPs: https://cwiki.apache.org/confluence/display/KAFKA/KIP-146+-+Classloading+Isolation+in+Connect and https://cwiki.apache.org/confluence/display/KAFKA/KIP-898%3A+Modernize+Connect+plugin+discovery > We can close it. I agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
