omkreddy commented on code in PR #16046:
URL: https://github.com/apache/kafka/pull/16046#discussion_r1616962390
##########
bin/kafka-run-class.sh:
##########
@@ -340,9 +340,13 @@ CLASSPATH=${CLASSPATH#:}
# If Cygwin is detected, classpath is converted to Windows format.
(( WINDOWS_OS_FORMAT )) && CLASSPATH=$(cygpath --path --mixed "${CLASSPATH}")
-# Launch mode
-if [ "x$DAEMON_MODE" = "xtrue" ]; then
- nohup "$JAVA" $KAFKA_HEAP_OPTS $KAFKA_JVM_PERFORMANCE_OPTS
$KAFKA_GC_LOG_OPTS $KAFKA_JMX_OPTS $KAFKA_LOG4J_CMD_OPTS -cp "$CLASSPATH"
$KAFKA_OPTS "$@" > "$CONSOLE_OUTPUT_FILE" 2>&1 < /dev/null &
+if [ "$KAFKA_MODE" = "native" ]; then
+ exec $base_dir/kafka.Kafka start --config "$2" $KAFKA_LOG4J_CMD_OPTS
$KAFKA_JMX_OPTS $KAFKA_OPTS
Review Comment:
Dont we need to pass `$KAFKA_HEAP_OPTS` to native run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
