jeffkbkim commented on code in PR #15974:
URL: https://github.com/apache/kafka/pull/15974#discussion_r1613821741
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpecImpl.java:
##########
@@ -33,44 +35,74 @@ public class AssignmentSpec {
*/
private final SubscriptionType subscriptionType;
- public AssignmentSpec(
+ /**
+ * Reverse lookup map representing topic partitions with
+ * their current member assignments.
+ */
+ private final Map<Uuid, Map<Integer, String>> invertedTargetAssignment;
+
+ public GroupSpecImpl(
Map<String, AssignmentMemberSpec> members,
- SubscriptionType subscriptionType
+ SubscriptionType subscriptionType,
+ Map<Uuid, Map<Integer, String>> invertedTargetAssignment
) {
Objects.requireNonNull(members);
this.members = members;
this.subscriptionType = subscriptionType;
+ this.invertedTargetAssignment = invertedTargetAssignment;
Review Comment:
Should this be
```
this.members = Objects.requireNonNull(members);
this.subscriptionType = Objects.requireNonNull(subscriptionType);
this.invertedTargetAssignment =
Objects.requireNonNull(invertedTargetAssignment);
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
