VedarthConfluent commented on code in PR #16045:
URL: https://github.com/apache/kafka/pull/16045#discussion_r1612040958


##########
.github/workflows/docker_promote.yml:
##########
@@ -19,10 +19,10 @@ on:
   workflow_dispatch:
     inputs:
       rc_docker_image:
-        description: RC docker image that needs to be promoted (Example:- 
apache/kafka:3.6.0-rc0)
+        description: RC docker image that needs to be promoted (Example:- 
apache/kafka:3.6.0-rc0, apache/kafka-native:3.6.0-rc0)

Review Comment:
   > maybe use apache/kafka:3.6.0-rc0 (or) apache/kafka-native:3.6.0-rc0
   +1
   
   native won't have 3.7.0 tag. Should we consider making it 3.8.0 in all 
examples?



##########
.github/workflows/docker_promote.yml:
##########
@@ -19,10 +19,10 @@ on:
   workflow_dispatch:
     inputs:
       rc_docker_image:
-        description: RC docker image that needs to be promoted (Example:- 
apache/kafka:3.6.0-rc0)
+        description: RC docker image that needs to be promoted (Example:- 
apache/kafka:3.6.0-rc0, apache/kafka-native:3.6.0-rc0)

Review Comment:
   > maybe use apache/kafka:3.6.0-rc0 (or) apache/kafka-native:3.6.0-rc0
   
   +1
   
   native won't have 3.7.0 tag. Should we consider making it 3.8.0 in all 
examples?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to