[
https://issues.apache.org/jira/browse/KAFKA-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577844#comment-16577844
]
ASF GitHub Bot commented on KAFKA-7211:
---------------------------------------
huxihx opened a new pull request #5492: KAFKA-7211: MM should handle
TimeoutException in commitSync
URL: https://github.com/apache/kafka/pull/5492
With KIP-266 introduced, MirrorMaker should handle TimeoutException thrown
in commitSync(). Besides, MM should only commit offsets for existsing topics.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> MM should handle timeouts in commitSync
> ---------------------------------------
>
> Key: KAFKA-7211
> URL: https://issues.apache.org/jira/browse/KAFKA-7211
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jason Gustafson
> Assignee: huxihx
> Priority: Major
>
> Now that we have KIP-266, the user can override `default.api.timeout.ms` for
> the consumer so that commitSync does not block indefinitely. MM needs to be
> updated to handle TimeoutException. We may also need some logic to handle
> deleted topics. If MM attempts to commit an offset for a deleted topic, the
> call will timeout and we should probably check if the topic exists and remove
> the offset if it doesn't.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
