mjsax commented on PR #15975: URL: https://github.com/apache/kafka/pull/15975#issuecomment-2123976338
Merged to `trunk` to make progress on the implementation of the KIP. About testing: I agree that we might not need to test every method which creates an iterator, but it would be great to test one method per "iterator type", per store? Ie, if there are two constructors for two iterator classed, we should try to test both by having a test for one method which create the one, or other iterator? About Sensor: you are right, that it currently does not support `Gauge`, but I am wondering if we could not just add it? The problem I see it, that `Sensor` seems to be a public API (even if I am not sure why...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
