rreddy-22 commented on code in PR #15974: URL: https://github.com/apache/kafka/pull/15974#discussion_r1608849959
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ########## @@ -516,16 +522,78 @@ public Assignment targetAssignment(String memberId) { return targetAssignment.getOrDefault(memberId, Assignment.EMPTY); } + /** + * @return An immutable map containing all the topic partitions + * with their current member assignments. + */ + public Map<Uuid, Map<Integer, String>> partitionAssignments() { + return Collections.unmodifiableMap(partitionAssignments); + } + /** * Updates target assignment of a member. * * @param memberId The member id. * @param newTargetAssignment The new target assignment. */ public void updateTargetAssignment(String memberId, Assignment newTargetAssignment) { + updatePartitionAssignments( + memberId, + targetAssignment.getOrDefault(memberId, new Assignment(Collections.emptyMap())), + newTargetAssignment + ); targetAssignment.put(memberId, newTargetAssignment); } + /** + * Updates partition assignments of the topics. + * + * @param memberId The member Id. + * @param oldTargetAssignment The old target assignment. + * @param newTargetAssignment The new target assignment. + * + * Package private for testing. + */ + void updatePartitionAssignments( Review Comment: used it in tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org