[
https://issues.apache.org/jira/browse/KAFKA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846959#comment-17846959
]
Bruno Cadonna commented on KAFKA-16774:
---------------------------------------
Looking at the test, I think we can remove that test and ensure we have a
corresponding test for the TaskManager. The test ensures that all task
producers are closed when the stream thread shuts down with EOS. Actually, it
would be enough to ensure that the TaskManager shuts down when the stream
thread shuts down and then have a unit test for task manager that verifies that
the producers is closed when the TaskManager is shut down.
> fix flaky StreamThreadTest#shouldCloseAllTaskProducersOnCloseIfEosEnabled
> -------------------------------------------------------------------------
>
> Key: KAFKA-16774
> URL: https://issues.apache.org/jira/browse/KAFKA-16774
> Project: Kafka
> Issue Type: Test
> Components: streams, unit tests
> Reporter: Chia-Ping Tsai
> Priority: Minor
> Labels: flaky-test
>
> java.util.ConcurrentModificationException
> at
> java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1720)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
> at
> org.apache.kafka.streams.processor.internals.TaskManager.allTasks(TaskManager.java:1686)
> at
> org.apache.kafka.streams.processor.internals.TaskManager.releaseLockedUnassignedTaskDirectories(TaskManager.java:1364)
> at
> org.apache.kafka.streams.processor.internals.TaskManager.handleRebalanceComplete(TaskManager.java:208)
> at
> org.apache.kafka.streams.processor.internals.StreamsRebalanceListener.onPartitionsAssigned(StreamsRebalanceListener.java:79)
> at
> org.apache.kafka.streams.processor.internals.StreamThreadTest.shouldCloseAllTaskProducersOnCloseIfEosEnabled(StreamThreadTest.java:1408)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
