vincent81jiang commented on code in PR #15904:
URL: https://github.com/apache/kafka/pull/15904#discussion_r1598902252
##########
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##########
@@ -488,8 +496,11 @@ class LogValidatorTest {
}
assertEquals(now + 1, validatingResults.maxTimestampMs,
s"Max timestamp should be ${now + 1}")
- assertEquals(2, validatingResults.shallowOffsetOfMaxTimestamp,
- "Shallow offset of max timestamp should be 2")
+
+ // Both V2 and V1 has single branch in the record when compression is
enable, and hence their shallow OffsetOfMaxTimestamp
+ // is the last offset of the single branch
+ assertEquals(1, records.batches().asScala.size)
Review Comment:
If I understand this test case correctly, there might still be a minor issue
with "checkRecompression":
1. at line 455, `records` should be created with "CompressionType.NONE".
2. at line 502, the check should be `assertEquals(1,
validatedRecords.batches().asScala.size)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
