gharris1727 commented on code in PR #15469:
URL: https://github.com/apache/kafka/pull/15469#discussion_r1598691348
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -766,135 +852,23 @@ protected static boolean
canParseSingleTokenLiteral(Parser parser, boolean embed
protected static SchemaAndValue parse(Parser parser, boolean embedded)
throws NoSuchElementException {
Review Comment:
I'm confused. Locally for me this doesn't appear in the API docs, and it's
because of this change: https://issues.apache.org/jira/browse/KAFKA-14839 . The
ticket says it's fixed in 3.5.0, and that commit is definitely in 3.6.0+ so it
should have applied when doing the 3.7.0 release.
I'm happy to preserve all of the protected methods (both the existing ones
in Values, and the whole Parser class) if these are truly public API, but if
this other commit already removed them from the Javadoc, I think we should try
and follow through on the renaming here. I just need to figure out how they
showed up in the 37 release docs...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
