chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465635
##########
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##########
@@ -79,7 +79,7 @@ public RaftClusterInvocationContext(String baseDisplayName,
ClusterConfig cluste
@Override
public String getDisplayName(int invocationIndex) {
- String clusterDesc = clusterConfig.nameTags().entrySet().stream()
+ String clusterDesc = clusterConfig.displayTags().stream()
.map(Object::toString)
.collect(Collectors.joining(", "));
return String.format("%s [%d] Type=Raft-%s, %s", baseDisplayName,
invocationIndex, isCombined ? "Combined" : "Isolated", clusterDesc);
Review Comment:
`return String.format("%s [%d] Type=Raft-%s, %s", baseDisplayName,
invocationIndex, isCombined ? "Combined" : "Isolated", String.join(",",
clusterConfig.displayTags()));`
##########
core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java:
##########
@@ -81,7 +81,7 @@ public ZkClusterInvocationContext(String baseDisplayName,
ClusterConfig clusterC
@Override
public String getDisplayName(int invocationIndex) {
- String clusterDesc = clusterConfig.nameTags().entrySet().stream()
+ String clusterDesc = clusterConfig.displayTags().stream()
.map(Object::toString)
.collect(Collectors.joining(", "));
return String.format("%s [%d] Type=ZK, %s", baseDisplayName,
invocationIndex, clusterDesc);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
