jeffkbkim commented on code in PR #15835: URL: https://github.com/apache/kafka/pull/15835#discussion_r1591194245
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorRuntimeMetrics.java: ########## @@ -208,8 +209,8 @@ public void recordEventQueueTime(long durationMs) { } public void recordEventQueueProcessingTime(long durationMs) { } @Override - public void recordThreadIdleRatio(double ratio) { - threadIdleRatioSensor.record(ratio); + public synchronized void recordThreadIdleTime(long idleTimeMs, long currentTimeMs) { + threadIdleTimeRate.record(metrics.config(), idleTimeMs, currentTimeMs); Review Comment: Thanks for the correction. Added the rate to the sensor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org