mjsax commented on PR #15689: URL: https://github.com/apache/kafka/pull/15689#issuecomment-2084338816
Thanks for the PR @florin-akermann. I agree with @AyoubOm that both statements you intend to remove are still correct? Seems the stream-stream join section did not talk about null-keys and thus left/outer join do not need an update? Might be worth to update the stream-stream inner join row, to point out that null-key records are dropped? I also just checked FK-left join, and it still says (this statement is missing for inner-join though): > Records for which the foreignKeyExtractor produces null are ignored and do not trigger a join. If you want to join with null foreign keys, use a suitable sentinel value to do so (i.e. "NULL" for a String field, or -1 for an auto-incrementing integer field). It seems https://github.com/apache/kafka/pull/14107 remove it incorrectly for inner join instead of left join? Might be worth to go over the docs once more to double check (I made a pass, but might have missed something). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
