cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {
assertEquals(0, result2.unsentRequests.size());
}
+ @Test
+ public void testSuccessfulHeartbeatTiming() {
+ mockStableMember();
+ NetworkClientDelegate.PollResult result =
heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(0, result.unsentRequests.size(),
+ "No heartbeat should be sent while interval has not expired");
+ long currentTimeMs = time.milliseconds();
+
assertEquals(heartbeatRequestState.timeToNextHeartbeatMs(currentTimeMs),
result.timeUntilNextPollMs);
+ assertNextHeartbeatTiming(DEFAULT_HEARTBEAT_INTERVAL_MS);
+
+ result = heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(1, result.unsentRequests.size(), "A heartbeat should be
sent when interval expires");
+ NetworkClientDelegate.UnsentRequest inflightReq =
result.unsentRequests.get(0);
+ inflightReq.handler().onComplete(createHeartbeatResponse(inflightReq,
Errors.NONE));
+ assertNextHeartbeatTiming(DEFAULT_HEARTBEAT_INTERVAL_MS);
Review Comment:
How do you know whether the heartbeat timer was reset in
`makeHeartbeatRequest()` or in `onResponse()` if you verify the reset after you
complete the future of the request?
I would verify the timer reset after the poll, progress the time a bit (less
then the heartbeat interval), and then verify here that the time to the next
heartbeat is the heartbeat interval minus the amount of time I progressed the
time after the poll.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
