[ https://issues.apache.org/jira/browse/KAFKA-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajini Sivaram updated KAFKA-7237: ---------------------------------- Description: We currently use FATAL markers for fatal error messages in core. But only logback supports markers out-of-the-box and log4j simply logs these as ERROR messages, ignoring the marker. We should perhaps include a String marker within these messages to make it easier to identify fatal messages in logs. >From https://www.slf4j.org/faq.html: {quote} While markers are part of the SLF4J API, only logback supports markers off the shelf. For example, if you add the {{%marker}}conversion word to its pattern, logback's {{PatternLayout}} will add marker data to its output. Marker data can be used to [filter messages|http://logback.qos.ch/manual/filters.html] or even [trigger|http://logback.qos.ch/manual/appenders.html#OnMarkerEvaluator] an outgoing email [at the end of an individual transaction|http://logback.qos.ch/recipes/emailPerTransaction.html]. In combination with logging frameworks such as log4j and java.util.logging which do not support markers, marker data will be silently ignored. {quote} was: We currently use FATAL markers for fatal error messages in core. But only logback supports markers out-of-the-box and log4j simply logs these as ERROR messages, ignoring the marker. We should perhaps include a String marker within these messages to make it easier to identify fatal messages in logs. >From https://www.slf4j.org/faq.html: While markers are part of the SLF4J API, only logback supports markers off the shelf. For example, if you add the {{%marker}}conversion word to its pattern, logback's {{PatternLayout}} will add marker data to its output. Marker data can be used to [filter messages|http://logback.qos.ch/manual/filters.html] or even [trigger|http://logback.qos.ch/manual/appenders.html#OnMarkerEvaluator] an outgoing email [at the end of an individual transaction|http://logback.qos.ch/recipes/emailPerTransaction.html]. In combination with logging frameworks such as log4j and java.util.logging which do not support markers, marker data will be silently ignored. > Add explicit fatal marker to fatal error messages > ------------------------------------------------- > > Key: KAFKA-7237 > URL: https://issues.apache.org/jira/browse/KAFKA-7237 > Project: Kafka > Issue Type: Bug > Components: core > Reporter: Rajini Sivaram > Priority: Minor > > We currently use FATAL markers for fatal error messages in core. But only > logback supports markers out-of-the-box and log4j simply logs these as ERROR > messages, ignoring the marker. We should perhaps include a String marker > within these messages to make it easier to identify fatal messages in logs. > From https://www.slf4j.org/faq.html: > {quote} > While markers are part of the SLF4J API, only logback supports markers off > the shelf. For example, if you add the {{%marker}}conversion word to its > pattern, logback's {{PatternLayout}} will add marker data to its output. > Marker data can be used to [filter > messages|http://logback.qos.ch/manual/filters.html] or even > [trigger|http://logback.qos.ch/manual/appenders.html#OnMarkerEvaluator] an > outgoing email [at the end of an individual > transaction|http://logback.qos.ch/recipes/emailPerTransaction.html]. > In combination with logging frameworks such as log4j and java.util.logging > which do not support markers, marker data will be silently ignored. > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)