philipnee commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1569554430
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##########
@@ -98,15 +98,15 @@ public NetworkClientDelegate.PollResult poll(final long
currentTimeMs) {
return EMPTY;
if (coordinatorRequestState.canSendRequest(currentTimeMs)) {
- NetworkClientDelegate.UnsentRequest request =
makeFindCoordinatorRequest(currentTimeMs);
+ NetworkClientDelegate.UnsentRequest request =
makeFindCoordinatorRequest();
return new NetworkClientDelegate.PollResult(request);
}
return new
NetworkClientDelegate.PollResult(coordinatorRequestState.remainingBackoffMs(currentTimeMs));
}
- NetworkClientDelegate.UnsentRequest makeFindCoordinatorRequest(final long
currentTimeMs) {
- coordinatorRequestState.onSendAttempt(currentTimeMs);
+ NetworkClientDelegate.UnsentRequest makeFindCoordinatorRequest() {
+ coordinatorRequestState.onSendAttempt();
Review Comment:
Thanks. This will fix some of the no-backoff issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
