[
https://issues.apache.org/jira/browse/KAFKA-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565731#comment-16565731
]
ASF GitHub Bot commented on KAFKA-7161:
---------------------------------------
guozhangwang closed pull request #5366: KAFKA-7161: check invariant: oldValue
is in the state
URL: https://github.com/apache/kafka/pull/5366
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableReduceTest.java
b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableReduceTest.java
new file mode 100644
index 00000000000..05b74dca9f4
--- /dev/null
+++
b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableReduceTest.java
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.kstream.internals;
+
+import org.apache.kafka.streams.processor.Processor;
+import org.apache.kafka.streams.processor.internals.AbstractProcessorContext;
+import org.apache.kafka.streams.processor.internals.ProcessorNode;
+import org.apache.kafka.streams.state.internals.InMemoryKeyValueStore;
+import org.apache.kafka.test.InternalMockProcessorContext;
+import org.junit.Test;
+
+import java.util.HashSet;
+import java.util.Set;
+
+import static java.util.Collections.emptySet;
+import static java.util.Collections.singleton;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class KTableReduceTest {
+
+ @Test
+ public void shouldAddAndSubtract() {
+ final AbstractProcessorContext context = new
InternalMockProcessorContext();
+
+ final Processor<String, Change<Set<String>>> reduceProcessor =
+ new KTableReduce<String, Set<String>>(
+ "myStore",
+ this::unionNotNullArgs,
+ this::differenceNotNullArgs
+ ).get();
+
+
+ final InMemoryKeyValueStore<String, Set<String>> myStore =
+ new InMemoryKeyValueStore<>("myStore", null, null);
+
+ context.register(myStore, null);
+ reduceProcessor.init(context);
+ context.setCurrentNode(new ProcessorNode<>("reduce", reduceProcessor,
singleton("myStore")));
+
+ reduceProcessor.process("A", new Change<>(singleton("a"), null));
+ assertEquals(singleton("a"), myStore.get("A"));
+ reduceProcessor.process("A", new Change<>(singleton("b"),
singleton("a")));
+ assertEquals(singleton("b"), myStore.get("A"));
+ reduceProcessor.process("A", new Change<>(null, singleton("b")));
+ assertEquals(emptySet(), myStore.get("A"));
+ }
+
+ private Set<String> differenceNotNullArgs(final Set<String> left, final
Set<String> right) {
+ assertNotNull(left);
+ assertNotNull(right);
+
+ final HashSet<String> strings = new HashSet<>(left);
+ strings.removeAll(right);
+ return strings;
+ }
+
+ private Set<String> unionNotNullArgs(final Set<String> left, final
Set<String> right) {
+ assertNotNull(left);
+ assertNotNull(right);
+
+ final HashSet<String> strings = new HashSet<>();
+ strings.addAll(left);
+ strings.addAll(right);
+ return strings;
+ }
+}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> KTable Reduce should check for invalid conditions
> -------------------------------------------------
>
> Key: KAFKA-7161
> URL: https://issues.apache.org/jira/browse/KAFKA-7161
> Project: Kafka
> Issue Type: Improvement
> Reporter: John Roesler
> Assignee: John Roesler
> Priority: Major
> Fix For: 2.1.0
>
>
> KTableReduce has the opportunity to explicitly check if the state is
> inconsistent with the oldValues arriving from the stream. If it did so, it
> could help detect topology changes that needed an app reset and fail fast
> before any data corruption occurs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
