[
https://issues.apache.org/jira/browse/KAFKA-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565498#comment-16565498
]
ASF GitHub Bot commented on KAFKA-7215:
---------------------------------------
stanislavkozlovski opened a new pull request #5439: KAFKA-7215: Improve
LogCleaner Error Handling
URL: https://github.com/apache/kafka/pull/5439
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
- Catch `KafkaStorageException` whose cause is `IOException` in
`CleanerThread#clean()`'s delete part. Properly mark the directory which caused
the IOException as "offline"
- Catch any exceptions raised during log cleaning and mark the partition
which caused it as "uncleanable". The log cleaner does not attempt to clean
said partitions afterwards
- Introduce new config - `max.uncleanable.partitions`. After X unclean
partitions in the same log directory, mark the log directory as offline
(assuming it is a disk problem)
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
JIRA: https://issues.apache.org/jira/browse/KAFKA-7215
Some notes and troubles:
I had to create a mock `LogCleanerManagerMock`, because I had problems
creating/setting/reading checkpoint files to ensure my tests worked. Not sure
if this is the best approach to the problem
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve LogCleaner behavior on error
> ------------------------------------
>
> Key: KAFKA-7215
> URL: https://issues.apache.org/jira/browse/KAFKA-7215
> Project: Kafka
> Issue Type: Improvement
> Reporter: Stanislav Kozlovski
> Assignee: Stanislav Kozlovski
> Priority: Minor
>
> For more detailed information see
> [KIP-346|https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
