cadonna commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1507827920
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java:
##########
@@ -97,6 +101,10 @@ public void setFetchAction(final FetchBuffer fetchBuffer) {
}
}
+ public void disableWakeups() {
Review Comment:
Could you please add unit tests for this new method?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##########
@@ -892,6 +893,24 @@ public void testWakeupCommitted() {
assertNull(consumer.wakeupTrigger().getPendingTask());
}
+ @Test
+ public void testNoWakeupInCloseCommit() {
Review Comment:
This unit test does not work for me locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
