[ 
https://issues.apache.org/jira/browse/KAFKA-16282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820821#comment-17820821
 ] 

Justine Olshan commented on KAFKA-16282:
----------------------------------------

Thanks [~ahmedsobeh] 

A few things:
For the Admin.java proposed change, picking one of the options and listing the 
other as a rejected alternative. We may go with one or the other, but it is 
good to take an opinion for folks to agree or disagree with. 

For the compatibility section, we could have compatibility issues if someone 
uses this new field on a broker that doesn't support it. We should probably 
throw and error in that case. 

Generally though, I think the KIP is ready for discussion, I may have further 
comments for you on the mailing list :) 

> Allow to get last stable offset (LSO) in kafka-get-offsets.sh
> -------------------------------------------------------------
>
>                 Key: KAFKA-16282
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16282
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Luke Chen
>            Assignee: Ahmed Sobeh
>            Priority: Major
>              Labels: need-kip, newbie, newbie++
>
> Currently, when using `kafka-get-offsets.sh` to get the offset by time, we 
> have these choices:
> {code:java}
> --time <String: <timestamp> /              timestamp of the offsets before 
> that. 
>   -1 or latest /                           [Note: No offset is returned, if 
> the
>   -2 or earliest /                         timestamp greater than recently
>   -3 or max-timestamp /                    committed record timestamp is
>   -4 or earliest-local /                   given.] (default: latest)
>   -5 or latest-tiered      
> {code}
> For the "latest" option, it'll always return the "high watermark" because we 
> always send with the default option: *IsolationLevel.READ_UNCOMMITTED*. It 
> would be good if the command can support to get the last stable offset (LSO) 
> for transaction support. That is, sending the option with 
> *IsolationLevel.READ_COMMITTED*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to