cadonna commented on code in PR #15369:
URL: https://github.com/apache/kafka/pull/15369#discussion_r1496159485
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -708,14 +709,18 @@ public ConsumerRecords<K, V> poll(final Duration timeout)
{
wakeupTrigger.maybeTriggerWakeup();
updateAssignmentMetadataIfNeeded(timer);
- final Fetch<K, V> fetch = pollForFetches(timer);
- if (!fetch.isEmpty()) {
- if (fetch.records().isEmpty()) {
- log.trace("Returning empty records from `poll()` "
+ if (isGenerationKnown()) {
Review Comment:
The busy loop should not be too bad since the group metadata update event is
added to the queue when also the new assignment is set in the membership
manager.
Moreover, this is kind of a temporary solution until
https://issues.apache.org/jira/browse/KAFKA-16285 is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
