lucasbru commented on code in PR #15275:
URL: https://github.com/apache/kafka/pull/15275#discussion_r1485888892


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -929,6 +938,9 @@ private void revokeAndAssign(SortedSet<TopicIdPartition> 
assignedTopicIdPartitio
                     String reason = interruptedReconciliationErrorMessage();
                     log.error("Interrupting reconciliation after partitions 
assigned callback " +
                         "completed. " + reason);
+                    if (memberHasRejoined) {
+                        attemptReconciliation = true;

Review Comment:
   The point was that we avoid the reconciliation-on-every-poll when metadata 
is missing by using `attemptReconciliation`, and I think we had to enable it 
here as well. However, since we decided that reconciliation-on-every-poll is 
fine for a short timeframe where metadata is incomplete, this does not matter 
anymore, I removed it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to