gaurav-narula commented on code in PR #15232:
URL: https://github.com/apache/kafka/pull/15232#discussion_r1466767964
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1408,6 +1408,7 @@ void handleDirectoriesOffline(
(short) 2));
log.warn("Directories {} in broker {} marked offline, remaining
directories: {}",
newOfflineDirs, brokerId, newOnlineDirs);
+ // XXX If the result of this is the broker has no online
directories then fence.
Review Comment:
Wouldn't `newOfflineDirs` and `newOnlineDirs` will always be empty until the
BrokerRegistrationRecord is updated because they are set operations
(intersection, difference) on the list of directories during BrokerRegistration
which is an empty set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
