lianetm commented on code in PR #15202:
URL: https://github.com/apache/kafka/pull/15202#discussion_r1463372247
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -536,12 +543,23 @@ public void onResponse(final ClientResponse response) {
continue;
}
- if (error == Errors.COORDINATOR_NOT_AVAILABLE ||
+ if (error == Errors.GROUP_AUTHORIZATION_FAILED) {
+
future.completeExceptionally(GroupAuthorizationException.forGroupId(groupId));
+ return;
+ } else if (error == Errors.COORDINATOR_NOT_AVAILABLE ||
error == Errors.NOT_COORDINATOR ||
error == Errors.REQUEST_TIMED_OUT) {
coordinatorRequestManager.markCoordinatorUnknown(error.message(),
currentTimeMs);
maybeRetry(currentTimeMs, error.exception());
return;
+ } else if (error == Errors.FENCED_INSTANCE_ID) {
+ log.info("OffsetCommit failed due to group instance id
{} fenced: {}", groupInstanceId, error.message());
+ future.completeExceptionally(new
CommitFailedException());
Review Comment:
Oh maybe just a confusion...I notice now that on the main PR page it still
shows the `log.info`, but we do have the `log.error` I introduced in
[this](https://github.com/apache/kafka/pull/15202/commits/f7b76fd75de6615ac089c6c8ff24166fc5683a2d)
previous commit , so maybe just github tricking us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
