jolshan commented on code in PR #15087:
URL: https://github.com/apache/kafka/pull/15087#discussion_r1458143981
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1188,18 +1073,7 @@ class ReplicaManager(val config: KafkaConfig,
requestLocal: RequestLocal,
verificationErrors: Map[TopicPartition, Errors]
): Unit = {
- // Map transaction coordinator errors to known errors for the response
- val convertedErrors = verificationErrors.map { case (tp, error) =>
- error match {
- case Errors.CONCURRENT_TRANSACTIONS |
- Errors.COORDINATOR_LOAD_IN_PROGRESS |
- Errors.COORDINATOR_NOT_AVAILABLE |
- Errors.NOT_COORDINATOR => tp -> Errors.NOT_ENOUGH_REPLICAS
- case _ => tp -> error
- }
-
- }
Review Comment:
But yes, we simply pass through concurrent txns which will be fatal to the
client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
