OmniaGM commented on code in PR #15158:
URL: https://github.com/apache/kafka/pull/15158#discussion_r1446236478


##########
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##########
@@ -51,15 +52,9 @@ case class ClientSensors(metricTags: Map[String, String], 
quotaSensor: Sensor, t
  *
  */
 case class ClientQuotaManagerConfig(numQuotaSamples: Int =

Review Comment:
   Defaults depends only on `ClientQuotaManagerConfig` object companion only. 
Moving `ClientQuotaManagerConfig` class can happened when we move 
`ClientQuotaManager` or in another pr as this will impact QuotaFactory and some 
Quota test classes 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to