dajac commented on code in PR #15017:
URL: https://github.com/apache/kafka/pull/15017#discussion_r1446100144
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##########
@@ -187,13 +188,16 @@ class CoordinatorLoaderImpl[T](
}
val endTimeMs = time.milliseconds()
+ info(s"Finished loading offsets and group metadata from $tp "
+ + s"in ${endTimeMs - startTimeMs} milliseconds, of which " +
+ s"$schedulerTimeMs milliseconds was spent in the scheduler.")
Review Comment:
We already have a similar log in CoordinatorRuntime. I wonder if we should
remove this one and extend the existing one. What do you think?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java:
##########
@@ -53,12 +53,16 @@ public short unknownType() {
class LoadSummary {
private final long startTimeMs;
private final long endTimeMs;
+ private final long totalTimeMs;
Review Comment:
I think that we don't need this field. We can just compute it.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java:
##########
@@ -53,12 +53,16 @@ public short unknownType() {
class LoadSummary {
private final long startTimeMs;
private final long endTimeMs;
+ private final long totalTimeMs;
+ private final long schedulerTimeMs;
Review Comment:
I wonder if we could find a better name here. They don't really describe
well what they are. We could perhaps use startTimeMs, startLoadingTimeMs,
endTimeMs. I am open to other suggestions too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
