akaltsikis commented on code in PR #15078:
URL: https://github.com/apache/kafka/pull/15078#discussion_r1443743036
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4394,7 +4394,10 @@ public ListTransactionsResult
listTransactions(ListTransactionsOptions options)
public FenceProducersResult fenceProducers(Collection<String>
transactionalIds, FenceProducersOptions options) {
AdminApiFuture.SimpleAdminApiFuture<CoordinatorKey,
ProducerIdAndEpoch> future =
FenceProducersHandler.newFuture(transactionalIds);
- FenceProducersHandler handler = new FenceProducersHandler(logContext);
+ if (options.timeoutMs() == null) {
+ options.timeoutMs(defaultApiTimeoutMs);
Review Comment:
Thanks for the good comment.
The main reason i mutated the options was to pass the same timeout value in
both the `FenceProducersHandler` and in the `invokeDriver`.
I just noticed that this is already true as the
[calcDeadlineMs](https://github.com/apache/kafka/blob/8d1a1dd7f2655e411e48ef5043b1385fd9804991/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L469-L473)
that is used by the `invokeDriver` is already returning the
`defaultApiTimeoutMs` in the case of null timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
