showuon commented on PR #15133: URL: https://github.com/apache/kafka/pull/15133#issuecomment-1878605296
> Okay, correct me if I am wrong - your idea is that we will use the aggregate object to either store partitions->values or topics->values. For the case where we don't have a topic tag we use the second, in all other cases we use the first. Correct! > If this is correct, we need to add the brokerTopicStats.allTopicsStats()... to where we record each metric, no? Right, Like this: https://github.com/apache/kafka/pull/15133/files#diff-380e4d8859ea9148f21794c09039425c82d9012a392c2dbbe1ce2ec8677a1970R792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
