divijvaidya commented on code in PR #15115: URL: https://github.com/apache/kafka/pull/15115#discussion_r1440702318
########## .github/workflows/pr_reviews.yml: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Adding Reviewers + +on: + pull_request_review: + types: [submitted] + +jobs: + add_reviewers: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Add Reviewers + run: | + user_json=$(gh api users/${{ github.event.review.user.login }}) Review Comment: we should probably explicitly specify the `accept` in the header to `-H "Accept: application/vnd.github+json" \` as per https://docs.github.com/en/rest/users/users?apiVersion=2022-11-28 Also maybe the version to `-H "X-GitHub-Api-Version: 2022-11-28" \` ########## .github/workflows/pr_reviews.yml: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Adding Reviewers + +on: + pull_request_review: + types: [submitted] + +jobs: + add_reviewers: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Add Reviewers + run: | + user_json=$(gh api users/${{ github.event.review.user.login }}) + user_name=$(echo "$user_json" | jq -r '.name') + user_email=$(echo "$user_json" | jq -r '.email') + if [[ "${{ github.event.pull_request.body }}" =~ ^.*Reviewers:\ .*${user_name}.*$ ]]; then Review Comment: nit You can extract out pull_request.body into a variable since it's used multiple times. The code becomes ``` run: | user_json=$(gh api users/${{ github.event.review.user.login }}) user_name=$(echo "$user_json" | jq -r '.name') user_email=$(echo "$user_json" | jq -r '.email') pr_body="${{ github.event.pull_request.body }}" if [[ "$pr_body" =~ ^.*Reviewers:\ .*${user_name}.*$ ]]; then echo "Reviewer already added: ${user_name} <${user_email}>" else if [[ "$pr_body" =~ ^.*Reviewers:\ .*$ ]]; then pr_body+=", ${user_name} <${user_email}>" else pr_body+="Reviewers: ${user_name} <${user_email}>" fi gh pr edit ${{ github.event.pull_request.number }} --body "$pr_body" echo "Added reviewer: ${user_name} <${user_email}>" fi ``` ########## .github/workflows/pr_reviews.yml: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Adding Reviewers + +on: + pull_request_review: + types: [submitted] + +jobs: + add_reviewers: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Add Reviewers + run: | + user_json=$(gh api users/${{ github.event.review.user.login }}) + user_name=$(echo "$user_json" | jq -r '.name') + user_email=$(echo "$user_json" | jq -r '.email') + if [[ "${{ github.event.pull_request.body }}" =~ ^.*Reviewers:\ .*${user_name}.*$ ]]; then + echo "Reviewer already added: ${user_name} <${user_email}>" + elif [[ "${{ github.event.pull_request.body }}" =~ ^.*Reviewers:\ .*$ ]]; then + pr_body="${{ github.event.pull_request.body }}, ${user_name} <${user_email}>" + gh pr edit ${{ github.event.pull_request.number }} --body "${pr_body}" + echo "Added reviewer: ${user_name} <${user_email}>" + else + pr_body="${{ github.event.pull_request.body }} + + Reviewers: ${user_name} <${user_email}>" Review Comment: indentation seems off here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
