Phuc-Hong-Tran commented on code in PR #15020:
URL: https://github.com/apache/kafka/pull/15020#discussion_r1440167093
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##########
@@ -781,10 +781,10 @@ public void testFetchSkipsBlackedOutNodes() {
Node node = initialUpdateResponse.brokers().iterator().next();
client.backoff(node, 500);
- assertEquals(0, sendFetches());
+ assertEquals(1, sendFetches());
Review Comment:
Since we're not checking the node availablity using the
networkClientDelegate in FetchRequestManager, the request that was made would
pass through the check and made it way to unsentRequest. After the backoff the
request should be sent already.
Should I not change the test and make new one instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
