satishd commented on code in PR #15077:
URL: https://github.com/apache/kafka/pull/15077#discussion_r1437344252
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -167,7 +167,7 @@ class ReplicaManagerTest {
.foreach(checkpointFile => assertTrue(Files.exists(checkpointFile),
s"checkpoint file does not exist at $checkpointFile"))
} finally {
- rm.shutdown(checkpointHW = false)
+ CoreUtils.swallow(rm.shutdown(checkpointHW = false), this)
Review Comment:
Why is the exception swallowed here and all other places with the latest
change? I did not mean to suggest this in my review. I clarified that in
another
[comment](https://github.com/apache/kafka/pull/15077#discussion_r1437341409).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
