showuon opened a new pull request, #15065:
URL: https://github.com/apache/kafka/pull/15065

   As @stanislavkozlovski found 
[here](https://gist.github.com/stanislavkozlovski/8959f7ee59434f774841f4ae2f5228c2),
 there are some tests ran more than 1 ~ 2 hours, which make our CI build meet 8 
hours timeout. We should set a timeout for each test as 10 mins using a junit5 
feature 
[here](https://junit.org/junit5/docs/current/user-guide/#writing-tests-declarative-timeouts-default-timeouts).
 If it exceeds 10m, we should fail them, and investigate/improve them. This 
way, we can resolve the CI timeout issue.
   
   If it exceeds the timeout, it'll fail with the exception:
   ```
   Gradle Test Run :storage:test > Gradle Test Executor 21 > 
TransactionsWithTieredStoreTest > 
testDelayedFetchIncludesAbortedTransaction(String) > 
testDelayedFetchIncludesAbortedTransaction(String).quorum=zk FAILED
       java.util.concurrent.TimeoutException: 
testDelayedFetchIncludesAbortedTransaction(java.lang.String) timed out after 10 
seconds
           at 
org.junit.jupiter.engine.extension.TimeoutExceptionFactory.create(TimeoutExceptionFactory.java:29)
           at 
org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:58)
           at 
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
   ```
   
   However, the stream tests are still using junit4, we can only set timeout 
for each test suite. I added timeout for `KTableKTableLeftJoinTest` as 
highlighted 
[here](https://gist.github.com/stanislavkozlovski/8959f7ee59434f774841f4ae2f5228c2).
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to