dajac commented on code in PR #15059:
URL: https://github.com/apache/kafka/pull/15059#discussion_r1434063518
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -319,40 +319,40 @@ public Long value() {
registry.newGauge(NUM_GENERIC_GROUPS_PREPARING_REBALANCE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numGenericGroups(GenericGroupState.PREPARING_REBALANCE);
+ return numGenericGroups(ClassicGroupState.PREPARING_REBALANCE);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_COMPLETING_REBALANCE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return
numGenericGroups(GenericGroupState.COMPLETING_REBALANCE);
+ return
numGenericGroups(ClassicGroupState.COMPLETING_REBALANCE);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_STABLE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numGenericGroups(GenericGroupState.STABLE);
+ return numGenericGroups(ClassicGroupState.STABLE);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_DEAD, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numGenericGroups(GenericGroupState.DEAD);
+ return numGenericGroups(ClassicGroupState.DEAD);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_EMPTY, new
com.yammer.metrics.core.Gauge<Long>() {
Review Comment:
We don't have any existing metrics using "generic". They are all new in 3.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
