atu-sharm commented on code in PR #14893:
URL: https://github.com/apache/kafka/pull/14893#discussion_r1433807388
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##########
@@ -770,6 +771,9 @@ public void testSyncTopicConfigs() throws
InterruptedException {
Map<ConfigResource, Collection<AlterConfigOp>> configOps =
Collections.singletonMap(configResource, ops);
// alter configs on target cluster
backup.kafka().incrementalAlterConfigs(configOps);
+ // wait until the configs are changed
+ waitForConfigValueChange(backup, backupTopic, "delete.retention.ms",
"2000");
+ waitForConfigValueChange(backup, backupTopic, "retention.bytes",
"2000");
Review Comment:
Thanks, @ashwinpankaj, @C0urante, and @mimaison for taking the time to look
into this. I agree with @C0urante. Since we have waited for all the results to
come in and backup.kafka().incrementalAlterConfigs(configOps) didn't fail with
any exceptions, further assertions to confirm that the configs have been set
may not be beneficial.
Currently, the test fails with the delete.retention.ms value as 86400000
(which is the default value). As I'm new here, could you please provide more
insights? There are multiple tests (namely testSyncTopicConfigs,
testReplicateSourceDefault, testReplicateTargetDefault) and multiple classes
extending this test class (IdentityReplicationIntegrationTest,
MirrorConnectorsIntegrationExactlyOnceTest, etc). Is it possible that these
tests, which are calling MM or altering the same topic config and if are
running on different Gradle executors, could encounter a race condition and
cause the tests to fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
