philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432201481
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -195,6 +195,7 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
NetworkClientDelegate.UnsentRequest request =
makeHeartbeatRequest(currentTimeMs, true);
// We can ignore the leave response because we can join before or
after receiving the response.
heartbeatRequestState.reset();
+ heartbeatState.reset();
Review Comment:
One example would be fenced exception - we need to reset before sending a
joining heartbeat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
