philipnee commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1416378676
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -198,6 +219,17 @@ public long maximumTimeToWait(long currentTimeMs) {
return heartbeatNow ? 0L :
heartbeatRequestState.nextHeartbeatMs(currentTimeMs);
}
+ /**
+ * When consumer polls, we need to reset the pollTimer. If member is
already leaving the group
+ */
+ public void ack() {
Review Comment:
The code is updated - but the pollTimer is updated on a regular cadence by
the HeartbeatRequestManager.poll(). this func is used to check if the timer has
been expired. If it was, then we reset the timer everytime we poll the
consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
