Owen-CH-Leung commented on PR #14891: URL: https://github.com/apache/kafka/pull/14891#issuecomment-1837314577
> I don't think we want to directly call `TestUtils.createTopicWithAdmin` in this test for most cases. I didn't read through all of the tests, but I would imagine that most of these integration tests are trying to exercise the `topicService` logic. > > I would imagine it's probably sufficient to add a call to `ensureConsistentKRaftMetadata()` in `waitForTopicCreated` to deflake most failures, similar to the change in #14695 Not really. While part of the tests are exercising `topicService` logic, there're many other tests which test the creation /description of topics and do some assertions over number of partitions / replication status etc. And they were using old API `createAndWaitTopic()` / `adminClient.createTopics()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
