jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1412700208
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##########
@@ -322,7 +335,7 @@ public void testScheduleLoading() {
when(builder.build()).thenReturn(coordinator);
when(supplier.get()).thenReturn(builder);
CompletableFuture<CoordinatorLoader.LoadSummary> future = new
CompletableFuture<>();
- when(loader.load(TP, coordinator)).thenReturn(future);
+ when(loader.load(eq(TP), any())).thenReturn(future);
Review Comment:
i'm not sure how to go about this. The reason I had it this way was because
until we call `runtime.scheduleLoadOperation()`, we don't have a context for
the topic partition. but when we schedule a load operation we run
`loader.load()`. If there's a way, I'll make the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
