cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409941250
##########
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##########
@@ -42,13 +42,13 @@
"about": "The epoch of the partition leader." },
{ "name": "PartitionEpoch", "type": "int32", "versions": "0+", "default":
"-1",
"about": "An epoch that gets incremented each time we change anything in
the partition." },
+ { "name": "Directories", "type": "[]uuid", "versions": "1+",
+ "about": "The log directory hosting each replica, sorted in the same
exact order as the Replicas field."},
{ "name": "EligibleLeaderReplicas", "type": "[]int32", "default": "null",
"entityType": "brokerId",
- "versions": "1+", "nullableVersions": "1+", "taggedVersions": "1+",
"tag": 1,
+ "versions": "2+", "nullableVersions": "1+", "taggedVersions": "2+",
"tag": 1,
Review Comment:
fixed
##########
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##########
@@ -42,13 +42,13 @@
"about": "The epoch of the partition leader." },
{ "name": "PartitionEpoch", "type": "int32", "versions": "0+", "default":
"-1",
"about": "An epoch that gets incremented each time we change anything in
the partition." },
+ { "name": "Directories", "type": "[]uuid", "versions": "1+",
+ "about": "The log directory hosting each replica, sorted in the same
exact order as the Replicas field."},
{ "name": "EligibleLeaderReplicas", "type": "[]int32", "default": "null",
"entityType": "brokerId",
- "versions": "1+", "nullableVersions": "1+", "taggedVersions": "1+",
"tag": 1,
+ "versions": "2+", "nullableVersions": "1+", "taggedVersions": "2+",
"tag": 1,
"about": "The eligible leader replicas of this partition." },
{ "name": "LastKnownELR", "type": "[]int32", "default": "null",
"entityType": "brokerId",
- "versions": "1+", "nullableVersions": "1+", "taggedVersions": "1+",
"tag": 2,
- "about": "The last known eligible leader replicas of this partition." },
- { "name": "Directories", "type": "[]uuid", "versions": "2+",
- "about": "The log directory hosting each replica, sorted in the same
exact order as the Replicas field."}
+ "versions": "2+", "nullableVersions": "1+", "taggedVersions": "2+",
"tag": 2,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
