dajac commented on code in PR #14544:
URL: https://github.com/apache/kafka/pull/14544#discussion_r1408986511
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -943,4 +944,19 @@ private static Integer decValue(String key, Integer value)
{
private static Integer incValue(String key, Integer value) {
return value == null ? 1 : value + 1;
}
+
+ public ConsumerGroupDescribeResponseData.DescribedGroup
asDescribedGroup(long committedOffset, String defaultAssignor) {
+ ConsumerGroupDescribeResponseData.DescribedGroup describedGroup = new
ConsumerGroupDescribeResponseData.DescribedGroup()
+ .setGroupId(groupId)
+ .setAssignorName(preferredServerAssignor().orElse(defaultAssignor))
Review Comment:
You also need to take `committedOffset` into account for the
`preferredServerAssignor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
