mjsax commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1399921134
########## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryEmitter.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients; + +import org.apache.kafka.common.telemetry.internals.MetricKeyable; +import org.apache.kafka.common.telemetry.internals.MetricsEmitter; +import org.apache.kafka.common.telemetry.internals.SinglePointMetric; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.function.Predicate; + +public class ClientTelemetryEmitter implements MetricsEmitter { + + private final Predicate<? super MetricKeyable> selector; + private final List<SinglePointMetric> emitted; + private final boolean deltaMetrics; + + public ClientTelemetryEmitter(Predicate<? super MetricKeyable> selector, boolean deltaMetrics) { + this.selector = selector; + this.emitted = new ArrayList<>(); Review Comment: Was just going back to `MetricsEmitter` and JavaDoc says: ``` An {@code MetricsEmitter} is stateless ``` But `emitted` is clearly used to accumulate state. Can you elaborate of this difference? Given the implementation, I am actually not sure what "emitted" means here -- does it not mean sent to the broker? Does it instead mean, metric was "emitted' by the client code and thus this class actually _collects/buffers_ metrics until the next interval to them them to the brokers passed? If this is correct, is `MetricEmitter` a good name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
