tinaselenge commented on code in PR #14693:
URL: https://github.com/apache/kafka/pull/14693#discussion_r1407649223


##########
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala:
##########
@@ -212,7 +228,7 @@ class LogRecoveryTest extends QuorumTestHarness {
     server2.startup()
     updateProducer()
     // check if leader moves to the other server
-    leader = waitUntilLeaderIsElectedOrChanged(zkClient, topic, partitionId, 
oldLeaderOpt = Some(leader))
+    leader = awaitLeaderChange(servers, topicPartition, leader)

Review Comment:
   Is there a reason `awaitLeaderChange` cannot be used? It seems to be much 
quicker than `waitUntilLeaderIsElectedOrChangedWithAdmin` which does 
describeTopics(). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to