alok123t commented on PR #14687: URL: https://github.com/apache/kafka/pull/14687#issuecomment-1827838896
> Hey @alok123t. Thanks for working on this. In the last build, I just noticed that parameterized still are still reported as: > > ``` > Build / JDK 21 and Scala 2.13 / [5] Type=ZK, MetadataVersion=3.7-IV1, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest > ``` > > Shouldn't your patch fix those as well? @dajac Looks like these tests are based on the `@ClusterTest` annotation which internally overrides the `name()` https://github.com/apache/kafka/blob/af747fbfed7e81617c3b3ad0e4dc8c857aa9502b/core/src/test/java/kafka/test/annotation/ClusterTest.java#L41 and has it own custom implementation of overriding the name https://github.com/apache/kafka/blob/9b468fb278701be836a2641650356907bf84860a/core/src/test/java/kafka/test/junit/ClusterTestExtensions.java#L187 In case there are no other outstanding comments, shall we go ahead and merge this PR and we can fix the naming for the ones which use annotations in a subsequent PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
