apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1400049044


##########
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##########
@@ -103,9 +103,16 @@ class DynamicConfigPublisher(
               )
             case CLIENT_METRICS =>
               // Apply changes to client metrics subscription.
-              info(s"Updating client metrics subscription ${resource.name()} 
with new configuration : " +
-                toLoggableProps(resource, props).mkString(","))
-              
dynamicConfigHandlers(ConfigType.ClientMetrics).processConfigChanges(resource.name(),
 props)
+              
dynamicConfigHandlers.get(ConfigType.ClientMetrics).foreach(metricsConfigHandler
 =>
+                try {
+                  info(s"Updating client metrics ${resource.name()} with new 
configuration : " +
+                    toLoggableProps(resource, props).mkString(","))

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to