mjsax commented on code in PR #14769:
URL: https://github.com/apache/kafka/pull/14769#discussion_r1398520372
##########
streams/src/test/java/org/apache/kafka/streams/integration/IQv2IntegrationTest.java:
##########
@@ -418,6 +418,8 @@ public String metricsScope() {
})
);
+ // do not use the harness streams
Review Comment:
Not sure what this comment means?
##########
streams/src/test/java/org/apache/kafka/streams/integration/MetricsReporterIntegrationTest.java:
##########
@@ -125,6 +126,8 @@ public void
shouldBeAbleToProvideInitialMetricValueToMetricsReporter() {
final Object initialMetricValue =
METRIC_NAME_TO_INITIAL_VALUE.get(metricName.name());
assertThat(initialMetricValue, notNullValue());
});
+
+ kafkaStreams.close(Duration.ofSeconds(30));
Review Comment:
Should we use `try-with-resources` ? Do we need the timeout parameter (if
yes, might still be better to use a try-catch with `finally` block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
